Conversation
|
@Sheebazz Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #936
This PR introduces a deterministic
staletransaction state and an explicit user-driven refresh control for the draw-credit flow. It ensures that when network conditions or delays render a transaction status ambiguous, users receive clear feedback and a safe recovery path rather than facing silent data loss or an unrecoverable UI state.Implementation Details
Transactiontype union indraw-credit.types.tsandcreditLine.tsto include the"stale"status."stale"to the existingaccentcolor modifier andpendinggeometric pattern inTransactionStatus.tsx, adhering strictly toDESIGN_SYSTEM.mdconstraints against new inline hex values.onRefreshas an optional prop (onRefresh?: () => void), ensuring the 17 existing E2E callers (e.g.,RepayPage) remain completely unbroken.DrawCreditPage.tsxto handle theonRefreshcallback, triggering a loading state and re-polling the ledger status deterministically. This explicitly locks the UI (setIsLoading(true)) to prevent concurrent state mutation loops.Test Plan
TransactionStatus.patterns.test.tsx(now 28 tests passing) to verify"stale"renders the correct accessible pattern and text ("Status Unknown").status === "stale"and theonRefreshprop are provided.npm run build).